[ https://issues.apache.org/jira/browse/HBASE-17510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834371#comment-15834371 ]
Hadoop QA commented on HBASE-17510: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 18m 58s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 52s {color} | {color:green} branch-1 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 36s {color} | {color:green} branch-1 passed with JDK v1.8.0_121 {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 38s {color} | {color:green} branch-1 passed with JDK v1.7.0_80 {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 57s {color} | {color:green} branch-1 passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 17s {color} | {color:green} branch-1 passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 7s {color} | {color:red} hbase-server in branch-1 has 2 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 30s {color} | {color:green} branch-1 passed with JDK v1.8.0_121 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 35s {color} | {color:green} branch-1 passed with JDK v1.7.0_80 {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 45s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 36s {color} | {color:green} the patch passed with JDK v1.8.0_121 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 36s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 37s {color} | {color:green} the patch passed with JDK v1.7.0_80 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 37s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 57s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 17s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 16m 5s {color} | {color:green} The patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} | | {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m 16s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 19s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 28s {color} | {color:green} the patch passed with JDK v1.8.0_121 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 37s {color} | {color:green} the patch passed with JDK v1.7.0_80 {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 124m 30s {color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 19s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 174m 48s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.master.TestMasterBalanceThrottling | | | hadoop.hbase.client.TestMetaWithReplicas | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.12.6 Server=1.12.6 Image:yetus/hbase:e01ee2f | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12848864/HBASE-17510.branch-1.v0.patch | | JIRA Issue | HBASE-17510 | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux cd1e33d6d07e 3.13.0-100-generic #147-Ubuntu SMP Tue Oct 18 16:48:51 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/hbase.sh | | git revision | branch-1 / 6e0f3f5 | | Default Java | 1.7.0_80 | | Multi-JDK versions | /usr/lib/jvm/java-8-oracle:1.8.0_121 /usr/lib/jvm/java-7-oracle:1.7.0_80 | | findbugs | v3.0.0 | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/5410/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/5410/artifact/patchprocess/patch-unit-hbase-server.txt | | unit test logs | https://builds.apache.org/job/PreCommit-HBASE-Build/5410/artifact/patchprocess/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/5410/testReport/ | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/5410/console | | Powered by | Apache Yetus 0.3.0 http://yetus.apache.org | This message was automatically generated. > DefaultMemStore gets the wrong heap size after rollback > ------------------------------------------------------- > > Key: HBASE-17510 > URL: https://issues.apache.org/jira/browse/HBASE-17510 > Project: HBase > Issue Type: Bug > Reporter: ChiaPing Tsai > Assignee: ChiaPing Tsai > Fix For: 1.4.0 > > Attachments: HBASE-17510.branch-1.v0.patch > > > We should calculate the size of “found” rather than “cell” because the offset > value may cause the difference heap size between “cell” and “found”. > {code:title=DefaultMemStore.java|borderStyle=solid} > @Override > public void rollback(Cell cell) { > // If the key is in the memstore, delete it. Update this.size. > found = this.cellSet.get(cell); > if (found != null && found.getSequenceId() == cell.getSequenceId()) { > removeFromCellSet(cell); > long s = heapSizeChange(cell, true); > this.size.addAndGet(-s); > } > } > {code} > {code:title=KeyValue.java|borderStyle=solid} > @Override > public long heapSize() { > return ClassSize.align(sum) + > (offset == 0 > ? ClassSize.sizeOf(bytes, length) // count both length and object > overhead > : length); // only count the number of bytes > } > {code} > The wrong heap size of store will block the HRegion#doClose because the > HRegion#memstoreSize will always be bigger than zero even if we flush the > store. > {code:title=HRegion.java|borderStyle=solid} > while (this.memstoreSize.get() > 0) { > try { > if (flushCount++ > 0) { > int actualFlushes = flushCount - 1; > if (actualFlushes > 5) { > // If we tried 5 times and are unable to clear memory, abort > // so we do not lose data > throw new DroppedSnapshotException("Failed clearing memory > after " + > actualFlushes + " attempts on region: " + > Bytes.toStringBinary(getRegionInfo().getRegionName())); > } > LOG.info("Running extra flush, " + actualFlushes + > " (carrying snapshot?) " + this); > } > internalFlushcache(status); > } catch (IOException ioe) { > status.setStatus("Failed flush " + this + ", putting online > again"); > synchronized (writestate) { > writestate.writesEnabled = true; > } > // Have to throw to upper layers. I can't abort server from here. > throw ioe; > } > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)