[
https://issues.apache.org/jira/browse/HBASE-17552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15841811#comment-15841811
]
stack commented on HBASE-17552:
-------------------------------
If doing another cut, 1.0 has been EOL'd.
Soften this:
Refactor-only patches are exempted.
to .. 'It is hard to get review of refactor-only patches.'
bq. Make sure unit tests pass locally before submitting the patch, which is
faster than waiting for presubmit results. This will save your own time and
effort.
I'd change this. Our tests take an obnoxiously long time to run. New
contributors may be surprised. Suggest that they use jenkins to run the tests
because the full suite takes so long (don't worry if the run fails or breaks).
bq. Be sure to get the issue ID right, as this causes Jira to link to the
change in Git (use the issue's "All" tab to see these).
In here, point at your nice submit-patch scripts (smile).
--signoff is for when the patch is not your own?
Excellent [~appy]
> Update developer section in hbase book
> --------------------------------------
>
> Key: HBASE-17552
> URL: https://issues.apache.org/jira/browse/HBASE-17552
> Project: HBase
> Issue Type: Improvement
> Reporter: Appy
> Assignee: Appy
> Attachments: HBASE-17552.master.001.patch
>
>
> Updates
> - Changes 'Create Patch' in major way. Promoting use of submit-patch.py
> script.
> - Changes instructions for committing patch to make contributor of a patch
> also its author so proper credit is given to contributors in terms of github
> history.
> - Rewording in 'code formatting guidelines'
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
