[
https://issues.apache.org/jira/browse/HBASE-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15847271#comment-15847271
]
Ted Yu commented on HBASE-17261:
--------------------------------
[~zghaobac]:
I wasn't aware of your patch until Stack mentioned this JIRA over HBASE-17565
where I have a patch
(https://issues.apache.org/jira/secure/attachment/12849799/17565.v2.txt) which
fixes the same problem.
Your patch doesn't really fix the problem:
In StochasticLoadBalancer#setConf():
{code}
minCostNeedBalance = conf.getFloat(MIN_COST_NEED_BALANCE_KEY,
minCostNeedBalance);
{code}
This means if user sets non-zero value for
"hbase.master.balancer.stochastic.minCostNeedBalance", the change is not
effective.
If default value is used:
{code}
protected boolean needsBalance(Cluster cluster) {
+ if (minCostNeedBalance <= 0) {
+ return super.needsBalance(cluster);
{code}
The addition from HBASE-15529 would be skipped. I don't think that's what you
wanted.
What do you think ?
> Balancer makes no sense on tip of branch-1: says balanced when not
> ------------------------------------------------------------------
>
> Key: HBASE-17261
> URL: https://issues.apache.org/jira/browse/HBASE-17261
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: Guanghao Zhang
> Attachments: HBASE-17261.patch
>
>
> Running ITBLL on tip of branch-1, I see this in log when I try to balance:
> {code}
> 2016-12-05 16:42:21,031 INFO
> [RpcServer.deafult.FPBQ.Fifo.handler=46,queue=1,port=16000]
> balancer.StochasticLoadBalancer: Skipping load balancing because balanced
> cluster; total cost is 525.2547686174673|
> , sum multiplier is 111087.0 min cost which need balance is 0.05
> {code}
> Its some old nonsense.
> Does this every time I balance. Can't even force a balance.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
