[ 
https://issues.apache.org/jira/browse/HBASE-17582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15850347#comment-15850347
 ] 

Gary Helmling commented on HBASE-17582:
---------------------------------------

I took a look at the HBASE-15118 change to StoreFile.  It did remove the 
shouldDropCacheBehind private variable and replace it with the comment.  But it 
appears that the variable was unused even at that point.

On testing this, I don't really know.  It would be pretty difficult.  You could 
provide a way of overriding the HFileSystem used so that you can check that 
FSDataInputStream.setDropBehind(boolean) is eventually called with the right 
value.  But that would be pretty intrusive to do.  I'm not sure it's worth the 
effort unless anyone can see an easier way of validating this.

> Drop page cache hint is broken
> ------------------------------
>
>                 Key: HBASE-17582
>                 URL: https://issues.apache.org/jira/browse/HBASE-17582
>             Project: HBase
>          Issue Type: Bug
>          Components: Compaction, io
>    Affects Versions: 2.0.0
>            Reporter: Ashu Pachauri
>            Assignee: Appy
>            Priority: Critical
>         Attachments: HBASE-17582.master.001.patch
>
>
> We pass a boolean for pass page cache drop hint while creating store file 
> scanners and writers. 
> The hint is not passed on down the stack by StoreFileWriter and 
> StoreFileScanner in the master branch.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to