[
https://issues.apache.org/jira/browse/HBASE-17278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15851615#comment-15851615
]
Sudeep Sunthankar commented on HBASE-17278:
-------------------------------------------
Hi [~enis], I tested the patch. The patch looks fine except for the below
changes which were resulting in compilation and linking errors.
# {code}
KeyValueCodec() changed to public from private in keyvalue-codec.h
{code}
# Changed below declarations to pure virtual in codec.h
{code}
virtual std::unique_ptr<Encoder> CreateEncoder(std::shared_ptr<folly::IOBuf>
cell_block);
virtual std::unique_ptr<Decoder> CreateDecoder(std::shared_ptr<folly::IOBuf>
cell_block,
uint32_t
cell_block_start_offset,
uint32_t cell_block_length);
{code}
Thanks
> [C++] Cell Scanner Implementation to be used by ResultScanner
> -------------------------------------------------------------
>
> Key: HBASE-17278
> URL: https://issues.apache.org/jira/browse/HBASE-17278
> Project: HBase
> Issue Type: Sub-task
> Reporter: Sudeep Sunthankar
> Assignee: Sudeep Sunthankar
> Attachments: HBASE-17278.HBASE-14850.v1.patch,
> HBASE-17278.HBASE-14850.v2.patch, HBASE-17278.HBASE-14850.v3.patch,
> HBASE-17278.HBASE-14850.v4.patch, hbase-17278_v5.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
