[
https://issues.apache.org/jira/browse/HBASE-17578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15855000#comment-15855000
]
Hudson commented on HBASE-17578:
--------------------------------
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #2457 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/2457/])
HBASE-17578 Thrift metrics should handle exceptions (garyh: rev
7a6518f05d1e5b5ef2125fd996b13bdb35b79587)
* (edit)
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/HbaseHandlerMetricsProxy.java
* (edit)
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java
* (add)
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/metrics/ExceptionTrackingSourceImpl.java
* (add)
hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/ErrorThrowingGetObserver.java
* (edit)
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/thrift/MetricsThriftServerSource.java
* (add)
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/metrics/ExceptionTrackingSource.java
* (edit)
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSource.java
* (edit)
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/thrift/MetricsThriftServerSourceImpl.java
* (edit)
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
* (edit)
hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
* (edit)
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java
* (edit)
hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
* (edit)
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSourceImpl.java
> Thrift per-method metrics should still update in the case of exceptions
> -----------------------------------------------------------------------
>
> Key: HBASE-17578
> URL: https://issues.apache.org/jira/browse/HBASE-17578
> Project: HBase
> Issue Type: Bug
> Components: Thrift
> Reporter: Gary Helmling
> Assignee: Gary Helmling
> Fix For: 2.0.0, 1.4.0, 1.3.1
>
> Attachments: HBASE-17578.001.patch, HBASE-17578.002.patch,
> HBASE-17578.002.patch
>
>
> Currently, the InvocationHandler used to update per-method metrics in the
> Thrift server fails to update metrics if an exception occurs. This causes us
> to miss outliers. We should include exceptional cases in per-method
> latencies, and also look at adding specific exception rate metrics.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
