[ 
https://issues.apache.org/jira/browse/HBASE-17484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15855878#comment-15855878
 ] 

Anoop Sam John commented on HBASE-17484:
----------------------------------------

bq. ByteBufferUtils.toInt(this.buf, this.offset)
Repeating many a times..  We can have a private method named getKeyLen and u 
can return this from there.. For better readability
Else +1

> Add non cached version of OffheapKV for write path
> --------------------------------------------------
>
>                 Key: HBASE-17484
>                 URL: https://issues.apache.org/jira/browse/HBASE-17484
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver
>    Affects Versions: 2.0.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17484_1.patch, HBASE-17484.patch
>
>
> After running lot of different performance tests for various scenarios and 
> with multi threads we thought that is  better to have a version of OffheapKV 
> in write path that does not cache anything and its fixed_overhead is equal to 
> that in KeyValue. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to