[
https://issues.apache.org/jira/browse/HBASE-17613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858183#comment-15858183
]
Ted Yu commented on HBASE-17613:
--------------------------------
{code}
84 if (familySet.add(cell)) {
85 familyNames.add(CellUtil.cloneFamily(cell));
{code}
familyNames can be lazily created.
> avoid copy of family when initializing the FSWALEntry
> -----------------------------------------------------
>
> Key: HBASE-17613
> URL: https://issues.apache.org/jira/browse/HBASE-17613
> Project: HBase
> Issue Type: Improvement
> Reporter: ChiaPing Tsai
> Assignee: ChiaPing Tsai
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-17613.v0.patch, HBASE-17613.v1.patch
>
>
> We should compare the families before cloning it.
> {noformat}
> Set<byte[]> familySet = Sets.newTreeSet(Bytes.BYTES_COMPARATOR);
> for (Cell cell : cells) {
> if (!CellUtil.matchingFamily(cell, WALEdit.METAFAMILY)) {
> // TODO: Avoid this clone?
> familySet.add(CellUtil.cloneFamily(cell));
> }
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
