[ https://issues.apache.org/jira/browse/HBASE-5072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173366#comment-13173366 ]
Phabricator commented on HBASE-5072: ------------------------------------ Kannan has accepted the revision "[jira] [HBASE-5072] Support Max Value for Per-Store Metrics". +1. One small inlined comment. INLINE COMMENTS src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java:388 just noticed a minor thing in the comment. Perhaps this comment: also compute the max value across all Stores on this server should read: also compute the max value for a given Store (CF) across all regions on this server. ? REVISION DETAIL https://reviews.facebook.net/D945 > Support Max Value for Per-Store Metrics > --------------------------------------- > > Key: HBASE-5072 > URL: https://issues.apache.org/jira/browse/HBASE-5072 > Project: HBase > Issue Type: Improvement > Components: metrics, regionserver > Reporter: Nicolas Spiegelberg > Assignee: Nicolas Spiegelberg > Priority: Minor > Fix For: 0.94.0 > > Attachments: D945.1.patch, D945.2.patch > > > We were bit in our multi-tenant cluster because one of our Stores encountered > a bug and grew its StoreFile count. We didn't notice this because the > StoreFile count currently reported by the RegionServer is an average of all > Stores in the region. For the per-Store metrics, we should also record the > max so we can notice outliers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira