[ https://issues.apache.org/jira/browse/HBASE-17624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15868849#comment-15868849 ]
stack commented on HBASE-17624: ------------------------------- Let me open new issue [~toffer] since this is in and it has a bunch of stuff other than concurrency. HBASE-17653. I'll go through the code as was and apply above and list inconsistency or if none, then doc. the concurrency expectation. Thanks. Will ping you when I have something for you to look at. > Address late review of HBASE-6721, rsgroups feature > --------------------------------------------------- > > Key: HBASE-17624 > URL: https://issues.apache.org/jira/browse/HBASE-17624 > Project: HBase > Issue Type: Bug > Components: rsgroup > Reporter: stack > Assignee: stack > Fix For: 2.0.0 > > Attachments: HBASE-17624.master.001.patch, > HBASE-17624.master.002.patch, HBASE-17624.master.003.patch, > HBASE-17624.master.004.patch, HBASE-17624.master.005.patch, > HBASE-17624.master.006.patch, HBASE-17624.master.007.patch, > HBASE-17624.master.008.patch, HBASE-17624.master.009.patch, > HBASE-17624.master.010.patch > > > An internal review by [~busbey] and [~appy] turned up a bunch of good > findings going over HBASE-6721. They found some really good stuff a guava > type is part of our public API and concurrency in a few core classes is > inconsistent. > Patch coming. -- This message was sent by Atlassian JIRA (v6.3.15#6346)