[ https://issues.apache.org/jira/browse/HBASE-16188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871258#comment-15871258 ]
Hadoop QA commented on HBASE-16188: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 16s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 9 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 22s {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 8s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m 43s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m 34s {color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 11s {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 44s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m 44s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 29m 39s {color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m 48s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 1s {color} | {color:green} hbase-common in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 46s {color} | {color:green} hbase-procedure in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 24s {color} | {color:green} hbase-client in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 23s {color} | {color:green} hbase-prefix-tree in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 94m 20s {color} | {color:green} hbase-server in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m 33s {color} | {color:green} hbase-shell in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 22s {color} | {color:green} hbase-examples in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 24s {color} | {color:green} hbase-rest in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 12s {color} | {color:green} hbase-spark in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 36s {color} | {color:green} hbase-client-project in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 36s {color} | {color:green} hbase-shaded-client-project in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 126m 9s {color} | {color:red} root in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 3m 10s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 301m 14s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.thrift.TestThriftServerCmdLine | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:8d52d23 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12853181/HBASE-16188.patch | | JIRA Issue | HBASE-16188 | | Optional Tests | asflicense javac javadoc unit | | uname | Linux 7e6405f57ca6 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / ae840c0 | | Default Java | 1.8.0_121 | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/5744/artifact/patchprocess/patch-unit-root.txt | | unit test logs | https://builds.apache.org/job/PreCommit-HBASE-Build/5744/artifact/patchprocess/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/5744/testReport/ | | modules | C: hbase-common hbase-procedure hbase-client hbase-prefix-tree hbase-server hbase-shell hbase-examples hbase-rest hbase-spark hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/5744/console | | Powered by | Apache Yetus 0.3.0 http://yetus.apache.org | This message was automatically generated. > Add EventCounter information to log4j properties file > ----------------------------------------------------- > > Key: HBASE-16188 > URL: https://issues.apache.org/jira/browse/HBASE-16188 > Project: HBase > Issue Type: Improvement > Affects Versions: 1.2.1 > Reporter: Lars George > Assignee: Gopi Krishnan Nambiar > Priority: Minor > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-16188.patch > > > Hadoop's {{JvmMetrics}}, which HBase also is using in Metrics2 and provides > it as an MBean, has the ability to count log4j log calls. This is tracked by > a special {{Appender}} class, also provided by Hadoop, called > {{EventCounter}}. > We should add some info how to enable this (or maybe even enable it by > default?). > The appender needs to be added in two places, shown here: > {noformat} > hbase.root.logger=INFO,console > ... > # Define the root logger to the system property "hbase.root.logger". > log4j.rootLogger=${hbase.root.logger}, EventCounter > log4j.appender.EventCounter=org.apache.hadoop.log.metrics.EventCounter > {noformat} > We could simply add this commented out akin to the {{hbase-env.sh}}. -- This message was sent by Atlassian JIRA (v6.3.15#6346)