[ 
https://issues.apache.org/jira/browse/HBASE-17644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872026#comment-15872026
 ] 

Hudson commented on HBASE-17644:
--------------------------------

FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #2521 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/2521/])
HBASE-17644 Always create ByteBufferCells after copying to MSLAB. 
(anoopsamjohn: rev 7763dd6688254d37ad611f5d290db47c83cf93d3)
* (edit) 
hbase-common/src/main/java/org/apache/hadoop/hbase/codec/KeyValueCodec.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestTags.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMemStoreChunkPool.java
* (delete) 
hbase-common/src/main/java/org/apache/hadoop/hbase/OffheapKeyValue.java
* (edit) 
hbase-common/src/main/java/org/apache/hadoop/hbase/util/test/RedundantKVGenerator.java
* (delete) hbase-common/src/main/java/org/apache/hadoop/hbase/OffheapTag.java
* (add) hbase-common/src/main/java/org/apache/hadoop/hbase/ByteBufferTag.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALCellCodecWithCompression.java
* (add) 
hbase-common/src/main/java/org/apache/hadoop/hbase/ByteBufferKeyValue.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/protobuf/TestProtobufUtil.java
* (delete) 
hbase-common/src/test/java/org/apache/hadoop/hbase/TestOffheapKeyValue.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestDependentColumnFilter.java
* (add) 
hbase-common/src/test/java/org/apache/hadoop/hbase/TestByteBufferKeyValue.java
* (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java
* (edit) 
hbase-common/src/main/java/org/apache/hadoop/hbase/codec/KeyValueCodecWithTags.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMemStoreLAB.java
* (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/TagUtil.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestSeekTo.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestScannerFromBucketCache.java
* (edit) 
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/RowIndexSeekerV1.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/SimpleRegionObserver.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/ExpAsStringVisibilityLabelServiceImpl.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALReaderOnSecureWAL.java
* (add) 
hbase-common/src/main/java/org/apache/hadoop/hbase/NoTagsByteBufferKeyValue.java
* (edit) 
hbase-common/src/test/java/org/apache/hadoop/hbase/io/TestTagCompressionContext.java


> Always create ByteBufferCells after copying to MSLAB
> ----------------------------------------------------
>
>                 Key: HBASE-17644
>                 URL: https://issues.apache.org/jira/browse/HBASE-17644
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver
>    Affects Versions: 2.0.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17644.patch, HBASE-17644_V2.patch, 
> HBASE-17644_V3.patch
>
>
> We create a cell out of the Bytebuffer that is returned by MSLAB. This BB can 
> be offheap or onheap type. If MSLAB is full we return onheap byte buffer. So 
> the place where we create a cell by copying data to this buffer we either 
> create KeyValue or OffheapKV based on the buffer type. So what we saw in 
> tests is that since we have a combination of Cells the comparisons that 
> happens when adding to memstore happens millions of times and that has an 
> impact on the performance of write path. In read path this is not significant 
> enougth (though we have plans to just create one type of cells every where in 
> Server side). 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to