[ https://issues.apache.org/jira/browse/HBASE-17654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Appy updated HBASE-17654: ------------------------- Description: - Making rsGroupInfoManager non-static in RSGroupAdminEndpoint - Encapsulate RSGroupAdminService into an internal class in RSGroupAdminEndpoint (on need of inheritence). - Make RSGroupAdminEndpoint extend BaseMasterObserver, so got rid of unwanted empty implementations. - Change two internal classes in RSGroupAdminServer to non-static (so outer classes' variables can be shared). - Rename RSGroupSerDe to RSGroupProtobufUtil('ProtobufUtil' is what we use in other places). Moved 2 functions to RSGroupManagerImpl because they are only used there. - Javadoc comments - Improving variable names - Maybe other misc refactoring was:TBD > RSGroup code refactoring > ------------------------ > > Key: HBASE-17654 > URL: https://issues.apache.org/jira/browse/HBASE-17654 > Project: HBase > Issue Type: Improvement > Components: rsgroup > Reporter: Appy > Assignee: Appy > Attachments: HBASE-17654.master.001.patch, > HBASE-17654.master.002.patch, HBASE-17654.master.003.patch, > HBASE-17654.master.004.patch, HBASE-17654.master.005.patch > > > - Making rsGroupInfoManager non-static in RSGroupAdminEndpoint > - Encapsulate RSGroupAdminService into an internal class in > RSGroupAdminEndpoint (on need of inheritence). > - Make RSGroupAdminEndpoint extend BaseMasterObserver, so got rid of unwanted > empty implementations. > - Change two internal classes in RSGroupAdminServer to non-static (so outer > classes' variables can be shared). > - Rename RSGroupSerDe to RSGroupProtobufUtil('ProtobufUtil' is what we use in > other places). Moved 2 functions to RSGroupManagerImpl because they are only > used there. > - Javadoc comments > - Improving variable names > - Maybe other misc refactoring -- This message was sent by Atlassian JIRA (v6.3.15#6346)