[
https://issues.apache.org/jira/browse/HBASE-15314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15884214#comment-15884214
]
Ted Yu commented on HBASE-15314:
--------------------------------
{code}
+ return new FileIOEngine(capacity,
ioEngineName.substring(5).split(FileIOEngine.FILE_DELIMITER));
...
+ write(ByteBuffer.wrap(srcBuffer.array(), srcBuffer.arrayOffset(),
srcBuffer.remaining()), offset);
{code}
Wrap long line.
{code}
+ + " total space under " + filePath + ", not enough for applied "
{code}
"applied" -> "requested"
For the if block:
{code}
+ if (totalSpace < sizePerFile) {
{code}
Shouldn't sizePerFile be adjusted since total space is lower than sizePerFile ?
{code}
+ rafs[i].setLength(sizePerFile);
{code}
When total space is lower than sizePerFile, the above would raise exception,
right ?
For shutdown(), should the try block be moved inside the for loop ?
{code}
+ * Get the absolute offset in given file with the relative global offset.
{code}
What does "relative global" mean ?
For getFileNum(long offset), RuntimeException may be thrown. Should it declare
to throw IOE ?
> Allow more than one backing file in bucketcache
> -----------------------------------------------
>
> Key: HBASE-15314
> URL: https://issues.apache.org/jira/browse/HBASE-15314
> Project: HBase
> Issue Type: Sub-task
> Components: BucketCache
> Reporter: stack
> Assignee: Aaron Tokhy
> Attachments: FileIOEngine.java, HBASE-15314.master.001.patch,
> HBASE-15314.master.001.patch, HBASE-15314.patch, HBASE-15314-v2.patch,
> HBASE-15314-v3.patch, HBASE-15314-v4.patch
>
>
> Allow bucketcache use more than just one backing file: e.g. chassis has more
> than one SSD in it.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
