[
https://issues.apache.org/jira/browse/HBASE-17654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15884725#comment-15884725
]
Hudson commented on HBASE-17654:
--------------------------------
SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #2574 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/2574/])
HBASE-17654 RSGroup refactoring. (appy: rev
ce64e7eb6e9a6c3954b8ab6b5441ca6e4f952b26)
* (edit)
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManager.java
* (edit)
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminClient.java
* (edit)
hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsOfflineMode.java
* (edit)
hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroups.java
* (edit)
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java
* (edit)
hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/VerifyingRSGroupAdminClient.java
* (edit)
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupableBalancer.java
* (edit)
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdmin.java
* (edit)
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/rsgroup/IntegrationTestRSGroup.java
* (edit)
hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/master/balancer/TestRSGroupBasedLoadBalancer.java
* (edit)
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java
* (edit)
hbase-common/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfo.java
* (edit)
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.java
* (delete)
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupSerDe.java
* (edit)
hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.java
* (add)
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupProtobufUtil.java
> RSGroup code refactoring
> ------------------------
>
> Key: HBASE-17654
> URL: https://issues.apache.org/jira/browse/HBASE-17654
> Project: HBase
> Issue Type: Improvement
> Components: rsgroup
> Reporter: Appy
> Assignee: Appy
> Fix For: 2.0.0
>
> Attachments: HBASE-17654.master.001.patch,
> HBASE-17654.master.002.patch, HBASE-17654.master.003.patch,
> HBASE-17654.master.004.patch, HBASE-17654.master.005.patch,
> HBASE-17654.master.006.patch
>
>
> - Making rsGroupInfoManager non-static in RSGroupAdminEndpoint
> - Encapsulate RSGroupAdminService into an internal class in
> RSGroupAdminEndpoint (on need of inheritence).
> - Make RSGroupAdminEndpoint extend BaseMasterObserver, so got rid of unwanted
> empty implementations.
> - Change two internal classes in RSGroupAdminServer to non-static (so outer
> classes' variables can be shared).
> - Rename RSGroupSerDe to RSGroupProtobufUtil('ProtobufUtil' is what we use in
> other places). Moved 2 functions to RSGroupManagerImpl because they are only
> used there.
> - Javadoc comments
> - Improving variable names
> - Maybe other misc refactoring
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
