[ 
https://issues.apache.org/jira/browse/HBASE-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15884746#comment-15884746
 ] 

Duo Zhang commented on HBASE-17584:
-----------------------------------

Adding methods to an interface will cause compilation error for sub classes. It 
requires users to modify their code when upgrading from a previous version. Is 
it acceptable on a minor version upgrading? If we allow this type of breaking 
the compatibily(it is really a pain that we can not even add methods...), at 
least we need to modify the section of 'HBase version number and compatibility' 
in our hbase book.

Thanks.

> Expose ScanMetrics with ResultScanner rather than Scan
> ------------------------------------------------------
>
>                 Key: HBASE-17584
>                 URL: https://issues.apache.org/jira/browse/HBASE-17584
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Client, mapreduce, scan
>    Affects Versions: 2.0.0, 1.4.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0, 1.4.0
>
>         Attachments: HBASE-17584.patch
>
>
> I think this have been discussed many times... It is a bad practice to 
> directly modify the Scan object passed in when calling getScanner. The reason 
> that we can not use a copy is we need to use the Scan object to expose scan 
> metrics. So we need to find another way to expose the metrics.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to