[
https://issues.apache.org/jira/browse/HBASE-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173874#comment-13173874
]
Phabricator commented on HBASE-4916:
------------------------------------
stack has commented on the revision "HBASE-4916 [jira] LoadTest MR Job".
I started to review code then gave up to look more at what is attached.
This looks better than PE and more easily extended IMO. Good documentation
(could do w/ a package-info with overview of what it is and simple howto run
it). Nice it adds itself to Driver. I think we should commit it after some
fixup/review. I think it should go into tools package rather than into
loadtest package so it'd be tools.loadtest.
Nice one.
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/loadtest/CompositeOperationGenerator.java:1
Missing license.
src/main/java/org/apache/hadoop/hbase/loadtest/CompositeOperationGenerator.java:11
This looks promising
src/main/java/org/apache/hadoop/hbase/loadtest/CompositeOperationGenerator.java:78
isEmpty is cheaper than size() == 0
src/main/java/org/apache/hadoop/hbase/loadtest/CompositeOperationGenerator.java:90
These exceptions could come out here?
src/main/java/org/apache/hadoop/hbase/loadtest/DataGenerator.java:36 Whats a
column? A cf+qualifier written as cf:qualifier? Or is this just a cf?
src/main/java/org/apache/hadoop/hbase/loadtest/DataGenerator.java:71 Only
longs allowed as keys? Is key == row?
src/main/java/org/apache/hadoop/hbase/loadtest/DataGenerator.java:75 This
should be called constructPut rather than constructBulkPut
src/main/java/org/apache/hadoop/hbase/loadtest/DataGenerator.java:90 long key
'as String'...
src/main/java/org/apache/hadoop/hbase/loadtest/GetGenerator.java:109 Should
be logged at least rather than printStackTrace'd? Should we let it out?
src/main/java/org/apache/hadoop/hbase/loadtest/GetOperation.java:47 Logged
rather than printed
src/main/java/org/apache/hadoop/hbase/loadtest/KeyCounter.java:32 There is an
upper bound? Don't we need an upper bound so mappers don't overlap? Or is
that not wanted?
src/main/java/org/apache/hadoop/hbase/loadtest/KeyCounter.java:72 Why assign
here? Why not declare and allocate in the one go? Could make the data members
final then.
src/main/java/org/apache/hadoop/hbase/loadtest/KeyCounter.java:78 Should be
seeded?
REVISION DETAIL
https://reviews.facebook.net/D741
> LoadTest MR Job
> ---------------
>
> Key: HBASE-4916
> URL: https://issues.apache.org/jira/browse/HBASE-4916
> Project: HBase
> Issue Type: Sub-task
> Components: client, regionserver
> Reporter: Nicolas Spiegelberg
> Assignee: Christopher Gist
> Fix For: 0.94.0
>
> Attachments: HBASE-4916.D741.1.patch
>
>
> Add a script to start a streaming map-reduce job where each map tasks runs an
> instance of the load tester for a partition of the key-space. Ensure that the
> load tester takes a parameter indicating the start key for write operations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
