[ 
https://issues.apache.org/jira/browse/HBASE-16755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890881#comment-15890881
 ] 

Enis Soztutar commented on HBASE-16755:
---------------------------------------

bq. We pass true to make sure that we flush something out. So if we can make 
sure that we can flush something out when we pass false here, I think the patch 
is OK.
Indeed. when memstore is full, it is a force flush so we have to make sure that 
no matter what we are flushing something. Does the patch ensure that it 
happens?  

> Honor flush policy under global memstore pressure
> -------------------------------------------------
>
>                 Key: HBASE-16755
>                 URL: https://issues.apache.org/jira/browse/HBASE-16755
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Ashu Pachauri
>            Assignee: Ashu Pachauri
>             Fix For: 1.3.1
>
>         Attachments: HBASE-16755.v0.patch
>
>
> When global memstore reaches the low water mark, we pick the best flushable 
> region and flush all column families for it. This is a suboptimal approach in 
> the  sense that it leads to an unnecessarily high file creation rate and IO 
> amplification due to compactions. We should still try to honor the underlying 
> FlushPolicy.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to