[
https://issues.apache.org/jira/browse/HBASE-17716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893600#comment-15893600
]
Samarth Jain commented on HBASE-17716:
--------------------------------------
In Phoenix, we have a framework where we collect metrics for every sql
statement. The idea of PHOENIX-3248 is to include these scan metrics collected
by HBase to provide information on how much work the scans are doing for a sql.
I am guessing the dump in JMX or metrics page is probably just some aggregated
info so may not be useful for us.
bq. Is there a history of our randomly changing metric names out from under
phoenix (other than at say key junctions such as a major release?).
Well, this is the first time that we are exposing HBase scan metrics via
phoenix. We would like to have these metric names as constants to provide users
capability of looking up metrics of their choice via static metric names.
bq. And if enum'ing has a value, should we do it for all metrics rather than
just a subset as here?
Enums are just convenient. It could very well be strings defined as public
static final :). With enums though we can use an EnumMap which is more
performant and compact as compared to a HashMap.
> Formalize Scan Metric names
> ---------------------------
>
> Key: HBASE-17716
> URL: https://issues.apache.org/jira/browse/HBASE-17716
> Project: HBase
> Issue Type: Bug
> Components: metrics
> Reporter: Karan Mehta
> Assignee: Karan Mehta
> Priority: Minor
> Attachments: HBASE-17716.patch
>
>
> HBase provides various metrics through the API's exposed by ScanMetrics
> class.
> The JIRA PHOENIX-3248 requires them to be surfaced through the Phoenix
> Metrics API. Currently these metrics are referred via hard-coded strings,
> which are not formal and can break the Phoenix API. Hence we need to refactor
> the code to assign enums for these metrics.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
