[
https://issues.apache.org/jira/browse/HBASE-4951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174260#comment-13174260
]
Zhihong Yu commented on HBASE-4951:
-----------------------------------
Minor comments:
{code}
+ if (LOG.isTraceEnabled()) {
+ LOG.info(".META. still not available, sleeping and retrying." +
{code}
Should LOG.isInfoEnabled() be called above ?
The following two comments apply to ZooKeeperNodeTracker.java and
CatalogTracker.java:
{code}
+ // chk if the shutdown node is available. Because incase of cluster
+ // shutdonw
+ // this loop prevents the master from going down.
{code}
The above should read: check if the shutdown node exists. In case of cluster
shutdown, ...
{code}
+ "Unexpected exception handling while checking if shutdown node
exists.",
{code}
Extra word above: handling
> master process can not be stopped when it is initializing
> ---------------------------------------------------------
>
> Key: HBASE-4951
> URL: https://issues.apache.org/jira/browse/HBASE-4951
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.90.3
> Reporter: xufeng
> Assignee: ramkrishna.s.vasudevan
> Priority: Critical
> Fix For: 0.90.6
>
> Attachments: HBASE-4951.patch, HBASE-4951_branch.patch
>
>
> It is easy to reproduce by following step:
> step1:start master process.(do not start regionserver process in the cluster).
> the master will wait the regionserver to check in:
> org.apache.hadoop.hbase.master.ServerManager: Waiting on regionserver(s) to
> checkin
> step2:stop the master by sh command bin/hbase master stop
> result:the master process will never die because catalogTracker.waitForRoot()
> method will block unitl the root region assigned.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
