[ 
https://issues.apache.org/jira/browse/HBASE-17728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15899950#comment-15899950
 ] 

Enis Soztutar commented on HBASE-17728:
---------------------------------------

Thanks for the buck {{core:conf}} changes. It is better this way. 
This is not correct: 
{code}
+      hbase::HBaseConfigurationLoader loader;
+      hbase::optional<Configuration> conf_ = loader.LoadDefaultResources();
{code} 
Unlike in java, cpp does not enforce the usage of hbase-site.xml files. The 
configuration can be purely programmatic, or can come from non-XML sources. 
That is why you should not load a new conf object there. Instead conf should be 
obtained from the Client object in a non-static manner. 

> Create separate build target for Configuration classes
> ------------------------------------------------------
>
>                 Key: HBASE-17728
>                 URL: https://issues.apache.org/jira/browse/HBASE-17728
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 17728.v1.txt, 17728.v2.txt, 17728.v3.txt, 17728.v4.txt, 
> 17728.v5.txt, 17728.v6.txt
>
>
> User is in security module.
> When User::isSecurityEnabled() is added, we need to query Configuration for 
> security setting.
> However, this introduces a circular build dependency:
> BUILD FAILED: Cycle found: //connection:connection -> //security:security -> 
> //core:core -> //connection:connection
> This issue is to create separate build target for Configuration which is 
> depended upon by both core and security modules.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to