[ 
https://issues.apache.org/jira/browse/HBASE-15941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15902613#comment-15902613
 ] 

Stephen Yuan Jiang commented on HBASE-15941:
--------------------------------------------

{noformat}
            out.println("   -fixSplitParents  Try to force offline split 
parents to be online.");
            out.println("   -removeParents    Try to offline and sideline 
lingering parents and keep daughter regions.");
{noformat}

We are getting too many options now.  I just wonder whether we should have this 
new option or put logic in other options.  For example, maybe merge with 
-fixSplitParents option to either force offline parent online or sideline 
lingering parents.  (I am not sure about this, as I have not take a close look 
at this fixSplitParents code path.  I just feel HBCK already has too many 
options today; my experience with customer is that they sometimes miss the 
right option or sometimes they just simply use -repair to apply all options.)

> HBCK repair should not unsplit healthy splitted region
> ------------------------------------------------------
>
>                 Key: HBASE-15941
>                 URL: https://issues.apache.org/jira/browse/HBASE-15941
>             Project: HBase
>          Issue Type: Improvement
>          Components: hbck
>    Affects Versions: 1.0.0
>            Reporter: Stephen Yuan Jiang
>            Assignee: Esteban Gutierrez
>             Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.6
>
>         Attachments: HBASE-15941.branch-1.001.patch, 
> HBASE-15941.master.001.patch, HBASE-15941.master.001.patch, 
> HBASE-15941.master.002.patch
>
>
> Currently HBCK design in branch-1 has a flaw when repair option (the 
> -fixHdfsOverlaps option specifically) is specified: it would wrongly merge 
> split region (by looking at HDFS, it thinks that there exists overlapped 
> regions - parent region and daughter regions covers the same key range, of 
> course).  See HBASE-15940 for details.  
> This JIRA tracks the improvement not-to-merge split region in HBCK repair.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to