[
https://issues.apache.org/jira/browse/HBASE-16584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15903016#comment-15903016
]
Hadoop QA commented on HBASE-16584:
-----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 18s {color}
| {color:red} HBASE-16584 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.3.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12856998/HBASE-16584-v2.patch |
| JIRA Issue | HBASE-16584 |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/6032/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
> Backport the new ipc implementation in HBASE-16432 to branch-1
> --------------------------------------------------------------
>
> Key: HBASE-16584
> URL: https://issues.apache.org/jira/browse/HBASE-16584
> Project: HBase
> Issue Type: Task
> Components: Client, IPC/RPC
> Affects Versions: 1.4.0
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Fix For: 1.4.0
>
> Attachments: HBASE-16584-branch-1.patch,
> HBASE-16584-branch-1-v1.patch, HBASE-16584-v2.patch
>
>
> Two problems.
> First, as RpcCliemtImpl is the default implementation on branch-1, we need to
> confirm that the modification on master does not make it slower. I'm not sure
> but I used a big lock to protect everything in the new implementation, so it
> may have bad impact on performance.
> Second, some configurations of the old AsyncRpcClient is gone. Such as
> "hbase.rpc.client.threads.max" and "hbase.rpc.client.nativetransport". Now
> You could pass a EventLoopGroup object directly through a helper class which
> makes it more flexible.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
