[ 
https://issues.apache.org/jira/browse/HBASE-17723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15906330#comment-15906330
 ] 

Chia-Ping Tsai commented on HBASE-17723:
----------------------------------------

The isPrefetchRunning() may be executed between loadCache() and 
prefetchRunning.set(false), so we will end the iteration prematurely if the 
caching size is one (the caching is exhausted by last next()).

{noformat}
        if (prefetchCondition()) {
          // run prefetch in the background only if no prefetch is already 
running
          if (!isPrefetchRunning()) {
            if (prefetchRunning.compareAndSet(false, true)) {
              getPool().execute(prefetchRunnable);
            }
          }
        }
{noformat}

{noformat}
      try {
        loadCache();
      } catch (Exception e) {
        exceptionsQueue.add(e);
      } finally {
        prefetchRunning.set(false);
        if(closed) {
          if (closingThreadId.compareAndSet(NO_THREAD, 
Thread.currentThread().getId())) {
            // close was waiting for the prefetch to end
            close();
          }
        }
      }
    }
{noformat}

> TestServerSideScanMetricsFromClientSide and TestRecoveredEdits fail
> -------------------------------------------------------------------
>
>                 Key: HBASE-17723
>                 URL: https://issues.apache.org/jira/browse/HBASE-17723
>             Project: HBase
>          Issue Type: Bug
>          Components: integration tests
>    Affects Versions: 2.0.0
>         Environment: Ubuntu 14.04 LTS / x86_64 / 16GB RAM
>            Reporter: Anup Halarnkar
>
> Command to build and test:
> mvn clean install -X 
> JAVA_TOOL_OPTIONS: -Xmx4G -XX:MaxPermSize=4G -Xms1G
> Failure in tests:
> Results :
> Failed tests:
>   
> TestServerSideScanMetricsFromClientSide.testRowsSeenMetricWithAsync:161->testRowsSeenMetric:174->testRowsSeenMetric:204->testMetric:330
>  Metric: ROWS_SCANNED Expected: 9 Actual: 8 expected:<9> but was:<8>
>   
> TestRecoveredEdits.testReplayWorksThoughLotsOfFlushing:78->testReplayWorksWithMemoryCompactionPolicy:149->verifyAllEditsMadeItIn:195
>  Failed to find 
> W\xE1X\xDBv\xD8}\x07\xBF\xC1I\xF1\xF5\xB9\x84\xD8/meta:prev/1422491946444/Put/vlen=16/seqid=0
> Tests run: 1761, Failures: 2, Errors: 0, Skipped: 6
> ----------------------------------------------------------------------------------------
> This is the output for 1st test failure:
> -------------------------------------------------------------------------------
> Test set: org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide
> -------------------------------------------------------------------------------
> Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 7.971 sec <<< 
> FAILURE! - in org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide
> testRowsSeenMetricWithAsync(org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide)
>   Time elapsed: 1.134 sec  <<< FAILURE!
> java.lang.AssertionError: Metric: ROWS_SCANNED Expected: 9 Actual: 8 
> expected:<9> but was:<8>
>         at org.junit.Assert.fail(Assert.java:88)
>         at org.junit.Assert.failNotEquals(Assert.java:834)
>         at org.junit.Assert.assertEquals(Assert.java:645)
>         at 
> org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide.testMetric(TestServerSideScanMetricsFromClientSide.java:330)
>         at 
> org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide.testRowsSeenMetric(TestServerSideScanMetricsFromClientSide.java:204)
>         at 
> org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide.testRowsSeenMetric(TestServerSideScanMetricsFromClientSide.java:174)
>         at 
> org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide.testRowsSeenMetricWithAsync(TestServerSideScanMetricsFromClientSide.java:161)
> ------------------------------------------------------------------------------------
> This is output of 2nd test failure:
> -------------------------------------------------------------------------------
> Test set: org.apache.hadoop.hbase.regionserver.TestRecoveredEdits
> -------------------------------------------------------------------------------
> Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 11.911 sec 
> <<< FAILURE! - in org.apache.hadoop.hbase.regionserver.TestRecoveredEdits
> testReplayWorksThoughLotsOfFlushing(org.apache.hadoop.hbase.regionserver.TestRecoveredEdits)
>   Time elapsed: 11.871 sec  <<< FAILURE!
> java.lang.AssertionError: Failed to find 
> W\xE1X\xDBv\xD8}\x07\xBF\xC1I\xF1\xF5\xB9\x84\xD8/meta:prev/1422491946444/Put/vlen=16/seqid=0
>         at org.junit.Assert.fail(Assert.java:88)
>         at org.junit.Assert.assertTrue(Assert.java:41)
>         at 
> org.apache.hadoop.hbase.regionserver.TestRecoveredEdits.verifyAllEditsMadeItIn(TestRecoveredEdits.java:195)
>         at 
> org.apache.hadoop.hbase.regionserver.TestRecoveredEdits.testReplayWorksWithMemoryCompactionPolicy(TestRecoveredEdits.java:149)
>         at 
> org.apache.hadoop.hbase.regionserver.TestRecoveredEdits.testReplayWorksThoughLotsOfFlushing(TestRecoveredEdits.java:78)
> Please let me know if you need more information
> Thanks,
> Anup



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to