[
https://issues.apache.org/jira/browse/HBASE-14141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15924715#comment-15924715
]
Ted Yu commented on HBASE-14141:
--------------------------------
{code}
+ // convert WAL to HFiles and copy them to .tmp under BACKUP_ROOT
+ convertWALsAndCopy(backupInfo);
+ incrementalCopyHFiles(backupInfo);
{code}
Both methods have Copy in their names. What's the difference between the two
copy operations ?
{code}
+ LOG.info("Incremental copy HFiles is starting.");
{code}
Change to debug.
{code}
+ throw new IOException("Failed of Hadoop Distributed Copy from "
{code}
distcp seems to be implementation detail which can be omitted from the
exception message.
{code}
+ deleteBulkLoadDirectory();
{code}
Shouldn't the above be done in finally block ?
{code}
+ // TODO Player must tolerate missing files or exceptions during
conversion
{code}
The missing files have been filtered out, right ?
{code}
+ } catch (Exception e) {
+ throw new IOException("Can not convert from directory " + dirs
{code}
If e is already IOException, do we still need to create new IOException ?
{code}
+ String bulkOutputConfKey;
{code}
bulkOutputConfKey can be omitted - use WALPlayer.BULK_OUTPUT_CONF_KEY directly.
{code}
+ restoreService.run(paths, new TableName[]{tableName}, new TableName[]
{newTableName}, true);
{code}
Check return value from run() ?
{code}
+ return StringUtils.stringToPath(
+ inpDirs.split(conf.get(WALPlayer.INPUT_FILES_SEPARATOR_KEY, ",")));
{code}
Why not use semi colon as separator ?
> HBase Backup/Restore Phase 3: Filter WALs on backup to include only edits
> from backup tables
> --------------------------------------------------------------------------------------------
>
> Key: HBASE-14141
> URL: https://issues.apache.org/jira/browse/HBASE-14141
> Project: HBase
> Issue Type: New Feature
> Reporter: Vladimir Rodionov
> Assignee: Vladimir Rodionov
> Priority: Blocker
> Labels: backup
> Fix For: HBASE-7912
>
> Attachments: HBASE-14141.HBASE-14123.v1.patch, HBASE-14141.v1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
