[
https://issues.apache.org/jira/browse/HBASE-17707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935129#comment-15935129
]
Enis Soztutar commented on HBASE-17707:
---------------------------------------
bq. and this behavior is even unit tested
Sorry, I do not see it in the v11 or v9 patch? Maybe I'm missing something?
Most cost functions use the {{scale()}} function for doing a linear
normalization to the 0-1 range. I did not see that used in your patch thats why
I assumed that it is not normalized. However, a second look at the patch, you
are doing the normalization in here I think:
{code}
+ scaledSkewPerTable[table] = pathologicalNumMoves == 0 ? 0 : (double)
numMovesPerTable[table] / pathologicalNumMoves;
{code}
Is it a hard guarantee that always {{numMovesPerTable}} >=
{{pathologicalNumMoves}}?
Thanks for debugging the tests. I think your suggestion for a min replica cost
is fine, however, I am still curious to know whether we are affecting other
behavior. Maybe the typical costs from old table skew function versus new table
function is wildly different that causes the tests to fail? Did you attach the
patch?
We should still get these nice improvements to the table skew since it is one
of the frequent problems with the current SLB today. Do you mind doing the
changes suggested above.
> New More Accurate Table Skew cost function/generator
> ----------------------------------------------------
>
> Key: HBASE-17707
> URL: https://issues.apache.org/jira/browse/HBASE-17707
> Project: HBase
> Issue Type: New Feature
> Components: Balancer
> Affects Versions: 1.2.0
> Environment: CentOS Derivative with a derivative of the 3.18.43
> kernel. HBase on CDH5.9.0 with some patches. HDFS CDH 5.9.0 with no patches.
> Reporter: Kahlil Oppenheimer
> Assignee: Kahlil Oppenheimer
> Priority: Minor
> Fix For: 2.0
>
> Attachments: HBASE-17707-00.patch, HBASE-17707-01.patch,
> HBASE-17707-02.patch, HBASE-17707-03.patch, HBASE-17707-04.patch,
> HBASE-17707-05.patch, HBASE-17707-06.patch, HBASE-17707-07.patch,
> HBASE-17707-08.patch, HBASE-17707-09.patch, HBASE-17707-11.patch,
> HBASE-17707-11.patch, test-balancer2-13617.out
>
>
> This patch includes new version of the TableSkewCostFunction and a new
> TableSkewCandidateGenerator.
> The new TableSkewCostFunction computes table skew by counting the minimal
> number of region moves required for a given table to perfectly balance the
> table across the cluster (i.e. as if the regions from that table had been
> round-robin-ed across the cluster). This number of moves is computer for each
> table, then normalized to a score between 0-1 by dividing by the number of
> moves required in the absolute worst case (i.e. the entire table is stored on
> one server), and stored in an array. The cost function then takes a weighted
> average of the average and maximum value across all tables. The weights in
> this average are configurable to allow for certain users to more strongly
> penalize situations where one table is skewed versus where every table is a
> little bit skewed. To better spread this value more evenly across the range
> 0-1, we take the square root of the weighted average to get the final value.
> The new TableSkewCandidateGenerator generates region moves/swaps to optimize
> the above TableSkewCostFunction. It first simply tries to move regions until
> each server has the right number of regions, then it swaps regions around
> such that each region swap improves table skew across the cluster.
> We tested the cost function and generator in our production clusters with
> 100s of TBs of data and 100s of tables across dozens of servers and found
> both to be very performant and accurate.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
