[ https://issues.apache.org/jira/browse/HBASE-16438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15942980#comment-15942980 ]
ramkrishna.s.vasudevan commented on HBASE-16438: ------------------------------------------------ bq.We can "harden" the references in the map in the process of transferring to CellChunkMap (flattening). I agree to Anoop's point here. But am not sure how you mean this hardening it again. So considering the fact that if the ChunkID map was having soft ref to the Chunks and we added the cells from these chunks to CSLM as in the above use case of duplicate cells if the cells are removed from the CSLM and remove the ref to these chunks they can be GCed. So they are soft references here. So as per your idea, we create a CellChunkMap from these items in CSLM and that time we convert those chunk reference to harden references. How can that be done? The chunkId map will have a <Long, SoftRef(Chunk)> signature. So while converting to CellChunkMap every soft ref of this chunk should now be converted to a direct reference. Sorry I get your idea but not sure on the impl thing that you are suggesting here. > Create a cell type so that chunk id is embedded in it > ----------------------------------------------------- > > Key: HBASE-16438 > URL: https://issues.apache.org/jira/browse/HBASE-16438 > Project: HBase > Issue Type: Sub-task > Affects Versions: 2.0.0 > Reporter: ramkrishna.s.vasudevan > Assignee: ramkrishna.s.vasudevan > Attachments: HBASE-16438_1.patch, > HBASE-16438_3_ChunkCreatorwrappingChunkPool.patch, > HBASE-16438_4_ChunkCreatorwrappingChunkPool.patch, HBASE-16438.patch, > MemstoreChunkCell_memstoreChunkCreator_oldversion.patch, > MemstoreChunkCell_trunk.patch > > > For CellChunkMap we may need a cell such that the chunk out of which it was > created, the id of the chunk be embedded in it so that when doing flattening > we can use the chunk id as a meta data. More details will follow once the > initial tasks are completed. > Why we need to embed the chunkid in the Cell is described by [~anastas] in > this remark over in parent issue > https://issues.apache.org/jira/browse/HBASE-14921?focusedCommentId=15244119&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15244119 -- This message was sent by Atlassian JIRA (v6.3.15#6346)