[
https://issues.apache.org/jira/browse/HBASE-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951716#comment-15951716
]
Enis Soztutar commented on HBASE-17576:
---------------------------------------
- This should be ordered reverse?
{code}
+ return server_name ? "" : server_name->ShortDebugString();
{code}
- RawAsyncTable should remain async. All of the methods should return Futures,
rather than blocking on the results. So the following method will need to go to
table.cc instead.
{code}
+std::vector<std::shared_ptr<Result>> RawAsyncTable::Get(
{code}
- {{std::vector<std::shared_ptr<hbase::Get>>}} is already an instance of
{{std::vector<std::shared_ptr<Row>>}}, no? You should not need to copy the
vector.
{code}
+std::vector<std::shared_ptr<Result>> RawAsyncTable::Get(
+ const std::vector<std::shared_ptr<hbase::Get>>& gets) {
+ std::vector<std::shared_ptr<Row>> rows;
{code}
- In Get() when you call {{collectAll}}, and {{then()}}, you should also wait
for the results, before returning the response back to the caller.
> [C++] Implement request retry mechanism over RPC for Multi calls.
> -----------------------------------------------------------------
>
> Key: HBASE-17576
> URL: https://issues.apache.org/jira/browse/HBASE-17576
> Project: HBase
> Issue Type: Sub-task
> Reporter: Sudeep Sunthankar
> Assignee: Sudeep Sunthankar
> Attachments: HBASE-17576.HBASE-14850.v1.patch,
> HBASE-17576.HBASE-14850.v2.patch, HBASE-17576.HBASE-14850.v3.patch,
> HBASE-17576.HBASE-14850.v4.patch, HBASE-17576.HBASE-14850.v5.patch,
> HBASE-17576.HBASE-14850.v6.patch, HBASE-17576.HBASE-14850.v7.patch
>
>
> This work is based on top of HBASE-17465. Multi Calls will be based on this.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
