[
https://issues.apache.org/jira/browse/HBASE-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175518#comment-13175518
]
Zhihong Yu commented on HBASE-4224:
-----------------------------------
Putting the diff on review board allows me to see the changes easily.
Please submit review request there.
For ServerName.java:
{code}
+ * 2. post > 0
{code}
The above should read 'port > 0'
{code}
+ public boolean isValid() {
+ if(StringUtils.isNotBlank(hostname) && port > 0 && startcode > 0)
+ return true;
+ return false;
+ }
{code}
A single return statement should be enough.
For HBaseAdmin.java:
{code}
private ExecutorService executorService= Executors.newCachedThreadPool();
{code}
Please give ExecutorService better name and add javadoc for it.
> Need a flush by regionserver rather than by table option
> --------------------------------------------------------
>
> Key: HBASE-4224
> URL: https://issues.apache.org/jira/browse/HBASE-4224
> Project: HBase
> Issue Type: Bug
> Components: shell
> Reporter: stack
> Assignee: Akash Ashok
> Attachments: HBase-4224-v2.patch, HBase-4224.patch
>
>
> This evening needed to clean out logs on the cluster. logs are by
> regionserver. to let go of logs, we need to have all edits emptied from
> memory. only flush is by table or region. We need to be able to flush the
> regionserver. Need to add this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
