[
https://issues.apache.org/jira/browse/HBASE-17863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959811#comment-15959811
]
Appy commented on HBASE-17863:
------------------------------
so afaiu,
||old semantic||new semantic||
|finished and exception|FAILED|
|finished and no exception|SUCCESS|
They SUCCESS state implies no exception, then do we need the and condition below
{noformat}
public synchronized boolean isSuccess() {
return state == ProcedureState.SUCCESS && !hasException();
}
{noformat}
Why are we switching the order here?
{noformat}
- // Commit the transaction
- updateStoreOnExec(procStack, procedure, subprocs);
-
// if the store is not running we are aborting
if (!store.isRunning()) return;
+ // Commit the transaction
+ updateStoreOnExec(procStack, procedure, subprocs);
+
{noformat}
nit: (only in case there's an addendum) rename
ProcedureTestingUtility#setFinishedState to setSuccessState()
> Procedure V2: Some cleanup around Procedure.isFinished() and procedure
> executor
> -------------------------------------------------------------------------------
>
> Key: HBASE-17863
> URL: https://issues.apache.org/jira/browse/HBASE-17863
> Project: HBase
> Issue Type: Bug
> Components: proc-v2
> Reporter: Umesh Agashe
> Assignee: Umesh Agashe
> Fix For: 2.0.0
>
> Attachments: HBASE-17863.v1.patch, HBASE-17863.v2.patch,
> HBASE-17863.v3.patch, HBASE-17863.v3.patch, HBASE-17863.v4.patch,
> HBASE-17863.v4.patch
>
>
> Clean up around isFinished() and procedure executor
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
