[ 
https://issues.apache.org/jira/browse/HBASE-17863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Umesh Agashe updated HBASE-17863:
---------------------------------
    Attachment: HBASE-17863-addendum.v1.patch

Thanks [~appy] for reviewing this patch and your review comments. I appreciate 
for pointing out in comment #2 that reversing the order affects shutdown. I 
have reverted that change in the addendum. [[email protected]], [~appy] 
please review the addendum and let me know your feedback.

IMHO, that code can be improved in the long run including readability but 
considering the patch is already checked in addendum I have reverted the 
change. Addendum also has changes for comment #3.

re comment #1 The check is still needed, as the patch doesn't have any change 
with respect to letting set exception when procedure state is SUCCESS or 
ROLLEDBACK.

Thanks, Umesh


> Procedure V2:  Proc Executor cleanup. Split FINISHED state to two states: 
> SUCCESS and FAILED.
> ---------------------------------------------------------------------------------------------
>
>                 Key: HBASE-17863
>                 URL: https://issues.apache.org/jira/browse/HBASE-17863
>             Project: HBase
>          Issue Type: Bug
>          Components: proc-v2
>            Reporter: Umesh Agashe
>            Assignee: Umesh Agashe
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17863-addendum.v1.patch, HBASE-17863.v1.patch, 
> HBASE-17863.v2.patch, HBASE-17863.v3.patch, HBASE-17863.v3.patch, 
> HBASE-17863.v4.patch, HBASE-17863.v4.patch
>
>
> Clean up around isFinished() and procedure executor



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to