[
https://issues.apache.org/jira/browse/HBASE-5010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176033#comment-13176033
]
Phabricator commented on HBASE-5010:
------------------------------------
mbautin has commented on the revision "[jira] [HBASE-5010] Filter HFiles based
on TTL".
Lars: replying to your comments inline. I started addressing them but Ted
addressed some of them and committed the patch first :) Not sure if anything
was done about emphasizing the incompatibility of this fix with MIN_VERSIONS,
though. At least, this fix does not make things worse if MIN_VERSIONS is
nonzero. A performance penalty could only be incurred when there are entire
HFiles consisting of expired entries and MIN_VERSIONS is nonzero.
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java:737 Done.
src/main/java/org/apache/hadoop/hbase/regionserver/ExplicitColumnTracker.java:74
Done.
src/main/java/org/apache/hadoop/hbase/regionserver/ScanQueryMatcher.java:134
Done.
REVISION DETAIL
https://reviews.facebook.net/D1017
> Filter HFiles based on TTL
> --------------------------
>
> Key: HBASE-5010
> URL: https://issues.apache.org/jira/browse/HBASE-5010
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Zhihong Yu
> Attachments: 5010.patch, D1017.1.patch, D1017.2.patch, D909.1.patch,
> D909.2.patch
>
>
> In ScanWildcardColumnTracker we have
> {code:java}
>
> this.oldestStamp = EnvironmentEdgeManager.currentTimeMillis() - ttl;
> ...
> private boolean isExpired(long timestamp) {
> return timestamp < oldestStamp;
> }
> {code}
> but this time range filtering does not participate in HFile selection. In one
> real case this caused next() calls to time out because all KVs in a table got
> expired, but next() had to iterate over the whole table to find that out. We
> should be able to filter out those HFiles right away. I think a reasonable
> approach is to add a "default timerange filter" to every scan for a CF with a
> finite TTL and utilize existing filtering in
> StoreFile.Reader.passesTimerangeFilter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
