[ 
https://issues.apache.org/jira/browse/HBASE-16438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971109#comment-15971109
 ] 

Chia-Ping Tsai commented on HBASE-16438:
----------------------------------------

Some failed tests are shown below. We should make sure that all unit tests pass 
if we run them individually. (It may be a boring job...)
{noformat}
testReversibleStoreScanner(org.apache.hadoop.hbase.regionserver.TestReversibleScanners)
 Time elapsed: 0.512 sec <<< ERROR!
java.lang.NullPointerException: null
at 
org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.getOrMakeChunk(MemStoreLABImpl.java:242)
at 
org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.copyCellInto(MemStoreLABImpl.java:118)
at 
org.apache.hadoop.hbase.regionserver.Segment.maybeCloneWithAllocator(Segment.java:168)
at 
org.apache.hadoop.hbase.regionserver.AbstractMemStore.maybeCloneWithAllocator(AbstractMemStore.java:268)
at 
org.apache.hadoop.hbase.regionserver.AbstractMemStore.add(AbstractMemStore.java:107)
at 
org.apache.hadoop.hbase.regionserver.TestReversibleScanners.writeMemstoreAndStoreFiles(TestReversibleScanners.java:676)
at 
org.apache.hadoop.hbase.regionserver.TestReversibleScanners.testReversibleStoreScanner(TestReversibleScanners.java:252)
{noformat}

{noformat}
testUnflushedSeqIdTracking(org.apache.hadoop.hbase.regionserver.wal.TestFSHLog) 
 Time elapsed: 0.357 sec  <<< ERROR!
java.lang.NullPointerException: null
    at 
org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.getOrMakeChunk(MemStoreLABImpl.java:242)
    at 
org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.copyCellInto(MemStoreLABImpl.java:118)
    at 
org.apache.hadoop.hbase.regionserver.Segment.maybeCloneWithAllocator(Segment.java:168)
    at 
org.apache.hadoop.hbase.regionserver.AbstractMemStore.maybeCloneWithAllocator(AbstractMemStore.java:268)
    at 
org.apache.hadoop.hbase.regionserver.AbstractMemStore.add(AbstractMemStore.java:107)
    at 
org.apache.hadoop.hbase.regionserver.AbstractMemStore.add(AbstractMemStore.java:101)
    at org.apache.hadoop.hbase.regionserver.HStore.add(HStore.java:701)
    at 
org.apache.hadoop.hbase.regionserver.HRegion.applyToMemstore(HRegion.java:3952)
    at 
org.apache.hadoop.hbase.regionserver.HRegion.applyFamilyMapToMemstore(HRegion.java:3935)
    at 
org.apache.hadoop.hbase.regionserver.HRegion.doMiniBatchMutate(HRegion.java:3392)
    at 
org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3084)
    at 
org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3026)
    at 
org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3030)
    at 
org.apache.hadoop.hbase.regionserver.HRegion.doBatchMutate(HRegion.java:3778)
    at org.apache.hadoop.hbase.regionserver.HRegion.put(HRegion.java:2903)
    at 
org.apache.hadoop.hbase.regionserver.wal.TestFSHLog.testUnflushedSeqIdTracking(TestFSHLog.java:161)
{noformat}
Shall we declare the LOG as a static member ?
{noformat}
public class ChunkCreator {
private final Log LOG = LogFactory.getLog(ChunkCreator.class);
{noformat}

> Create a cell type so that chunk id is embedded in it
> -----------------------------------------------------
>
>                 Key: HBASE-16438
>                 URL: https://issues.apache.org/jira/browse/HBASE-16438
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 2.0.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>
>         Attachments: 
> HBASE-16438_10_ChunkCreatorwrappingChunkPool_withchunkRef.patch, 
> HBASE-16438_11_ChunkCreatorwrappingChunkPool_withchunkRef.patch, 
> HBASE-16438_12_ChunkCreatorwrappingChunkPool_withchunkRef.patch, 
> HBASE-16438_13_ChunkCreatorwrappingChunkPool_withchunkRef.patch, 
> HBASE-16438_13_ChunkCreatorwrappingChunkPool_withchunkRef.patch, 
> HBASE-16438_1.patch, HBASE-16438_3_ChunkCreatorwrappingChunkPool.patch, 
> HBASE-16438_4_ChunkCreatorwrappingChunkPool.patch, 
> HBASE-16438_8_ChunkCreatorwrappingChunkPool_withchunkRef.patch, 
> HBASE-16438_9_ChunkCreatorwrappingChunkPool_withchunkRef.patch, 
> HBASE-16438_addendum.patch, HBASE-16438.patch, 
> MemstoreChunkCell_memstoreChunkCreator_oldversion.patch, 
> MemstoreChunkCell_trunk.patch
>
>
> For CellChunkMap we may need a cell such that the chunk out of which it was 
> created, the id of the chunk be embedded in it so that when doing flattening 
> we can use the chunk id as a meta data. More details will follow once the 
> initial tasks are completed. 
> Why we need to embed the chunkid in the Cell is described by [~anastas] in 
> this remark over in parent issue 
> https://issues.apache.org/jira/browse/HBASE-14921?focusedCommentId=15244119&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15244119



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to