[
https://issues.apache.org/jira/browse/HBASE-5096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176052#comment-13176052
]
Hadoop QA commented on HBASE-5096:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12508642/5096.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -151 warning
messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 77 new Findbugs (version
1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
org.apache.hadoop.hbase.mapred.TestTableMapReduce
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/602//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/602//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/602//console
This message is automatically generated.
> Replication does not handle deletes correctly.
> ----------------------------------------------
>
> Key: HBASE-5096
> URL: https://issues.apache.org/jira/browse/HBASE-5096
> Project: HBase
> Issue Type: Sub-task
> Components: replication
> Affects Versions: 0.94.0, 0.92.1
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Attachments: 5096.txt
>
>
> Teruyoshi Zenmyo discovered this problem.
> The problem turns out to be this code in ReplicationSink.java:
> {code}
> if (kvs.get(0).isDelete()) {
> ...
> if (kv.isDeleteFamily()) {
> delete.deleteFamily(kv.getFamily());
> } else if (!kv.isEmptyColumn()) {
> delete.deleteColumn(kv.getFamily(), kv.getQualifier());
> }
> }
> ...
> {code}
> So the code deal with families delete markers and then assumes that if it's
> not a family delete marker it must have been a version delete marker.
> (deleteColumn sets a version delete marker, deleteColumns sets a column
> delete marker).
> I.e. column delete markers are not replicated correctly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
