[ 
https://issues.apache.org/jira/browse/HBASE-16314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975869#comment-15975869
 ] 

Ted Yu commented on HBASE-16314:
--------------------------------

{code}
45        public static final String BACKUP_ATTEMPTS_PAUSE_KEY = 
"hbase.backup.attempts.delay";
{code}
Consider including the unit of config in config key.
{code}
206           } catch (Exception ee) {
{code}
Catching IOE isn't enough ?
{code}
212               } catch (InterruptedException e) {
213                 Thread.currentThread().interrupt();
{code}
We should break out of the loop, right ?

> Retry on table snapshot failure
> -------------------------------
>
>                 Key: HBASE-16314
>                 URL: https://issues.apache.org/jira/browse/HBASE-16314
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Vladimir Rodionov
>            Assignee: Vladimir Rodionov
>              Labels: backup
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16314-v1.patch, HBASE-16314-v2.patch, 
> HBASE-16314-v3.patch, HBASE-16314-v4.patch, HBASE-16314-v5.patch
>
>
> Table snapshot (during full backup) can fail with NotServingRegionException 
> (splits, AM region moves). We need to add retry logic here.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to