[ 
https://issues.apache.org/jira/browse/HBASE-15199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976175#comment-15976175
 ] 

stack commented on HBASE-15199:
-------------------------------

I just tried assembly and yeah, nothing special done... the jruby jar ends up 
in same place as all other jars in ./lib/jruby-complete-1.6.8.jar ... So, this 
patch doesn't help (as per Sean). Need to change assembly so this jruby jar is 
elsewhere and then the hbase-shell goes and includes it from whereever it 
lives. In ./lib we currently have a ruby subdir which we make as part of 
assembly (long time since I dug in here... ) Could put jruby dir under there... 
or probably better, formalize where modules go to get extras... a 
lib/hbase-shell subdir... I'm sure there are better ideas and even conventions 
for how to do this but have spent no time digging.....

> Move jruby jar so only on hbase-shell module classpath; currently globally 
> available
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-15199
>                 URL: https://issues.apache.org/jira/browse/HBASE-15199
>             Project: HBase
>          Issue Type: Task
>          Components: dependencies, jruby, shell
>            Reporter: stack
>            Priority: Critical
>             Fix For: 2.0.0
>
>         Attachments: 15199.txt
>
>
> A suggestion that came up out of internal issue (filed by Mr Jan Van Besien) 
> was to move the scope of the jruby include down so it is only a dependency 
> for the hbase-shell. jruby jar brings in a bunch of dependencies (joda time 
> for example) which can clash with the includes of others. Our Sean suggests 
> that could be good to shut down exploit possibilities if jruby was not 
> globally available. Only downside I can think is that it may no longer be 
> available to our bin/*rb scripts if we move the jar but perhaps these can be 
> changed so they can find the ruby jar in new location.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to