[
https://issues.apache.org/jira/browse/HBASE-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15983525#comment-15983525
]
Andrew Purtell commented on HBASE-17448:
----------------------------------------
Great job [~ckulkarni].
We need to fix this:
{noformat}
Tests run: 6, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 11.094 sec <<<
FAILURE! - in org.apache.hadoop.hbase.TestInterfaceAudienceAnnotations
testInterfaceAudienceAnnotation(org.apache.hadoop.hbase.TestInterfaceAudienceAnnotations)
Time elapsed: 0.761 sec <<< FAILURE!
java.lang.AssertionError: All classes should have @InterfaceAudience annotation
expected:<0> but was:<1>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:645)
at
org.apache.hadoop.hbase.TestInterfaceAudienceAnnotations.testInterfaceAudienceAnnotation(TestInterfaceAudienceAnnotations.java:322)
{noformat}
I'm not sure why this test is failing. Let me look into it. If it is a quick
fix I will fix it upon commit later today.
> Export metrics from RecoverableZooKeeper
> ----------------------------------------
>
> Key: HBASE-17448
> URL: https://issues.apache.org/jira/browse/HBASE-17448
> Project: HBase
> Issue Type: Improvement
> Components: Zookeeper
> Affects Versions: 1.3.1
> Reporter: Andrew Purtell
> Assignee: Chinmay Kulkarni
> Labels: patch
> Fix For: 1.3.2
>
> Attachments: HBASE-17448.patch
>
>
> Consider adding instrumentation to RecoverableZooKeeper that exposes metrics
> on the performance and health of the embedded ZooKeeper client: latency
> histograms for each op type, number of reconnections, number of ops where a
> reconnection was necessary to proceed, number of failed ops due to
> CONNECTIONLOSS, number of failed ops due to SESSIONEXIPRED, number of failed
> ops due to OPERATIONTIMEOUT.
> RecoverableZooKeeper is a class in hbase-client so we can hook up the new
> metrics to both client- and server-side metrics reporters. Probably this
> metrics source should be a process singleton.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
