[
https://issues.apache.org/jira/browse/HBASE-16466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15987941#comment-15987941
]
Ted Yu commented on HBASE-16466:
--------------------------------
{code}
+import org.apache.hadoop.hbase.client.HTable;
{code}
The above is not used.
{code}
+ TableName tableName) throws IOException
+ {
{code}
Normally the right curly is at the end of previous line (applies to several
other places).
{code}
+ long startTime = 0;
+ long endTime = Long.MAX_VALUE;
{code}
Why are the above no longer static ?
{code}
+ String peerFSAddress = null;
+ String peerHBaseRootAddress = null;
{code}
Add comment explaining what the above are for.
{code}
+ endRow =
((TableSnapshotInputFormat.TableSnapshotRegionSplit)tableSplit).getRegionInfo().getEndKey();
{code}
Wrap long line - 100 chars max.
Enclose the line in pair of curlies (for both if and else).
{code}
+ scan.setStopRow(endRow);
{code}
The above can be lifted out of if / else since it is common.
{code}
- restoreDefaults();
{code}
Why is the above dropped ?
> HBase snapshots support in VerifyReplication tool to reduce load on live
> HBase cluster with large tables
> --------------------------------------------------------------------------------------------------------
>
> Key: HBASE-16466
> URL: https://issues.apache.org/jira/browse/HBASE-16466
> Project: HBase
> Issue Type: Improvement
> Components: hbase
> Affects Versions: 0.98.21
> Reporter: Sukumar Maddineni
> Assignee: Maddineni Sukumar
> Fix For: 1.3.1
>
> Attachments: HBASE-16466.branch-1.3.001.patch, HBASE-16466.v1.patch
>
>
> As of now VerifyReplicatin tool is running using normal HBase scanners. If
> you want to run VerifyReplication multiple times on a production live
> cluster with large tables then it creates extra load on HBase layer. So if we
> implement snapshot based support then both in source and target we can read
> data from snapshots which reduces load on HBase
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
