[
https://issues.apache.org/jira/browse/HBASE-17887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15989964#comment-15989964
]
Ted Yu commented on HBASE-17887:
--------------------------------
{code}
+ try {
+ this.lock.readLock().lock();
{code}
Taking read lock can be outside the try block.
{code}
+ if (!(ticket instanceof ScannerTicketImpl)) {
+ throw new RuntimeException("Unsupported ticket:" +
ticket.getClass().getName());
{code}
Throwing IOE is not enough ?
{code}
+ public void merge(ScannerTicket older) {
{code}
Consider declaring throwing IOE.
{code}
+ if (this.ticket != null) {
+ ticket.merge(this.ticket);
+ }
+ this.ticket = ticket;
{code}
Why not merging ticket to this.ticket ?
The test fails in master branch very often. Does this fix apply to master
branch ?
> TestAcidGuarantees fails frequently
> -----------------------------------
>
> Key: HBASE-17887
> URL: https://issues.apache.org/jira/browse/HBASE-17887
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 2.0.0
> Reporter: Umesh Agashe
> Priority: Blocker
> Attachments: HBASE-17887.branch-1.v0.patch,
> HBASE-17887.branch-1.v1.patch, HBASE-17887.branch-1.v1.patch
>
>
> As per the flaky tests dashboard here:
> https://builds.apache.org/job/HBASE-Find-Flaky-Tests/lastSuccessfulBuild/artifact/dashboard.html,
> It fails 30% of the time.
> While working on HBASE-17863, a few verification builds on patch failed due
> to TestAcidGuarantees didn't pass. IMHO, the changes for HBASE-17863 are
> unlikely to affect get/ put path.
> I ran the test with and without the patch several times locally and found
> that TestAcidGuarantees fails without the patch similar number of times.
> Opening blocker, considering acid guarantees are critical to HBase.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
