[
https://issues.apache.org/jira/browse/HBASE-17862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993513#comment-15993513
]
Hudson commented on HBASE-17862:
--------------------------------
SUCCESS: Integrated in Jenkins build HBase-1.1-JDK8 #1948 (See
[https://builds.apache.org/job/HBase-1.1-JDK8/1948/])
HBASE-17862 Fix a condition that always returns true (chia7712: rev
3f8636056150f1c50ad4e4eb2b0c239c6d89026d)
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
> Condition that always returns true
> ----------------------------------
>
> Key: HBASE-17862
> URL: https://issues.apache.org/jira/browse/HBASE-17862
> Project: HBase
> Issue Type: Bug
> Components: Client
> Reporter: JC
> Assignee: JC
> Priority: Trivial
> Fix For: 2.0.0, 1.4.0, 1.2.6, 1.3.2, 1.1.11
>
> Attachments:
> 0001-HBASE-17862-Fix-a-condition-that-always-returns-true.patch
>
>
> Hi
> In recent github mirror of hbase, I've found the following code smell.
> Path:
> hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
> {code}
> 209
> 210 ColumnPaginationFilter other = (ColumnPaginationFilter)o;
> 211 if (this.columnOffset != null) {
> 212 return this.getLimit() == this.getLimit() &&
> 213 Bytes.equals(this.getColumnOffset(), other.getColumnOffset());
> 214 }
> {code}
> It should be?
> {code}
> 212 return this.getLimit() == other.getLimit() &&
> {code}
> This might be just a code smell as Bytes.equals can be enough for the return
> value but wanted to report just in case.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
