[
https://issues.apache.org/jira/browse/HBASE-15199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15998483#comment-15998483
]
Xiang Li edited comment on HBASE-15199 at 5/5/17 3:45 PM:
----------------------------------------------------------
Hi Sean, the proposed change also change makes sense to me. The only reason for
me to keep the logic as it is now is we might need to leave a way for (senior)
operators to control JRUBY_HOME if they really want and be aware of the
consequence, even for server. But I am just wondering if it is really needed.
was (Author: water):
Hi Sean, the proposed also change makes sense to me. The only reason for me to
keep the logic as it is now is we might need to leave a way for (senior)
operators to control JRUBY_HOME if they really want and be aware of the
consequence, even for server. But I am just wondering if it is really needed.
> Move jruby jar so only on hbase-shell module classpath; currently globally
> available
> ------------------------------------------------------------------------------------
>
> Key: HBASE-15199
> URL: https://issues.apache.org/jira/browse/HBASE-15199
> Project: HBase
> Issue Type: Task
> Components: dependencies, jruby, shell
> Reporter: stack
> Assignee: Xiang Li
> Priority: Critical
> Fix For: 2.0.0
>
> Attachments: 15199.txt, HBASE-15199.master.001.patch,
> HBASE-15199.master.002.patch, HBASE-15199.master.003.patch
>
>
> A suggestion that came up out of internal issue (filed by Mr Jan Van Besien)
> was to move the scope of the jruby include down so it is only a dependency
> for the hbase-shell. jruby jar brings in a bunch of dependencies (joda time
> for example) which can clash with the includes of others. Our Sean suggests
> that could be good to shut down exploit possibilities if jruby was not
> globally available. Only downside I can think is that it may no longer be
> available to our bin/*rb scripts if we move the jar but perhaps these can be
> changed so they can find the ruby jar in new location.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
