[ https://issues.apache.org/jira/browse/HBASE-15199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15999251#comment-15999251 ]
Xiang Li commented on HBASE-15199: ---------------------------------- Hi [~busbey] I uploaded a new patch based on the current master branch. I never worked for a patch as "addendum" before, but it means a patch to contain the diff based on the current status, and does not contain the already committed changes for HBASE-15199, then it is as uploaded. Would you please review? The logic is updated as : (1) for the commands which need jruby (currently shell and org.jruby.Main) A. when JRUBY_HOME is specified explicitly, eg. export JRUBY_HOME=/usr/local/share/jruby CLASSPATH and HBASE_OPTS are updated according to JRUBY_HOME specified B. when JRUBY_HOME is not specified explicitly add jruby packaged with HBase to CLASSPATH (2) for other commands, do nothing > Move jruby jar so only on hbase-shell module classpath; currently globally > available > ------------------------------------------------------------------------------------ > > Key: HBASE-15199 > URL: https://issues.apache.org/jira/browse/HBASE-15199 > Project: HBase > Issue Type: Task > Components: dependencies, jruby, shell > Reporter: stack > Assignee: Xiang Li > Priority: Critical > Fix For: 2.0.0 > > Attachments: 15199.txt, HBASE-15199-addendum.master.000.patch, > HBASE-15199.master.001.patch, HBASE-15199.master.002.patch, > HBASE-15199.master.003.patch > > > A suggestion that came up out of internal issue (filed by Mr Jan Van Besien) > was to move the scope of the jruby include down so it is only a dependency > for the hbase-shell. jruby jar brings in a bunch of dependencies (joda time > for example) which can clash with the includes of others. Our Sean suggests > that could be good to shut down exploit possibilities if jruby was not > globally available. Only downside I can think is that it may no longer be > available to our bin/*rb scripts if we move the jar but perhaps these can be > changed so they can find the ruby jar in new location. -- This message was sent by Atlassian JIRA (v6.3.15#6346)