[ 
https://issues.apache.org/jira/browse/HBASE-18020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003926#comment-16003926
 ] 

Dima Spivak commented on HBASE-18020:
-------------------------------------

Some thoughts from a brief glance:
1. Can you put this up on Apache's Review Board?
2. Yay for using code from other projects, but are we sure we don't want to use 
Python 3 for this? Lots of lines of code in this patch could be removed/the 
whole thing made significantly more readable with some of the constructs 
introduced in Python 3 and, seeing as how we control our test environment with 
Docker and the like, there's no compelling reason not to use it. (Also, Python 
3 has been out for ten years. It's time to use it.)

> Update API Compliance Checker to Incorporate Improvements Done in Hadoop
> ------------------------------------------------------------------------
>
>                 Key: HBASE-18020
>                 URL: https://issues.apache.org/jira/browse/HBASE-18020
>             Project: HBase
>          Issue Type: Improvement
>          Components: API, community
>            Reporter: Alex Leblang
>            Assignee: Alex Leblang
>             Fix For: 2.0.0
>
>         Attachments: HBASE-18020.0.patch
>
>
> Recently the Hadoop community has made a number of improvements in their api 
> compliance checker based on feedback from the hbase and kudu community. We 
> should adopt these changes ourselves.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to