[
https://issues.apache.org/jira/browse/HBASE-18069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16016798#comment-16016798
]
Guanghao Zhang commented on HBASE-18069:
----------------------------------------
Take a look about HBASE-13057. The enableTableReplication will sink the table
schema change to peer cluster. But the disableTableReplication don't sink it to
peer cluster. So it is a mistake only for unit test.
> Fix flaky test
> TestReplicationAdminWithClusters#testDisableAndEnableReplication
> -------------------------------------------------------------------------------
>
> Key: HBASE-18069
> URL: https://issues.apache.org/jira/browse/HBASE-18069
> Project: HBase
> Issue Type: Bug
> Components: test
> Reporter: Chia-Ping Tsai
> Priority: Trivial
> Labels: beginner
> Fix For: 2.0.0, 1.4.0
>
>
> If we run testDisableAndEnableReplication, we will get the following error
> message.
> {code}
> testDisableAndEnableReplication(org.apache.hadoop.hbase.client.replication.TestReplicationAdminWithClusters)
> Time elapsed: 2.046 sec <<< FAILURE!
> java.lang.AssertionError: expected:<1> but was:<0>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:645)
> at org.junit.Assert.assertEquals(Assert.java:631)
> at
> org.apache.hadoop.hbase.client.replication.TestReplicationAdminWithClusters.testDisableAndEnableReplication(TestReplicationAdminWithClusters.java:160)
> {code}
> The critical code is shown below.
> {code}
> admin1.disableTableReplication(tableName);
> HTableDescriptor table = admin1.getTableDescriptor(tableName);
> for (HColumnDescriptor fam : table.getColumnFamilies()) {
> assertEquals(fam.getScope(), HConstants.REPLICATION_SCOPE_LOCAL);
> }
> table = admin2.getTableDescriptor(tableName);
> for (HColumnDescriptor fam : table.getColumnFamilies()) {
> assertEquals(fam.getScope(), HConstants.REPLICATION_SCOPE_LOCAL);
> }
> {code}
> Is HTD got from admin2 affected by admin1? I don't think so. We should remove
> the related assertion.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
