[
https://issues.apache.org/jira/browse/HBASE-18094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021285#comment-16021285
]
Ted Yu commented on HBASE-18094:
--------------------------------
lgtm
{code}
294
org.apache.hadoop.hbase.util.Bytes::toStringBinary(cell.getValueArray,
295 cell.getValueOffset, cell.getValueLength)
{code}
It is good practice to explicitly return the value.
See
https://stackoverflow.com/questions/1023146/is-it-good-style-to-explicitly-return-in-ruby
> Display the return value of the command append
> ----------------------------------------------
>
> Key: HBASE-18094
> URL: https://issues.apache.org/jira/browse/HBASE-18094
> Project: HBase
> Issue Type: Improvement
> Components: shell
> Affects Versions: 2.0.0, 1.3.1
> Reporter: Guangxu Cheng
> Assignee: Guangxu Cheng
> Attachments: HBASE-18094-branch-1.patch, HBASE-18094-master-v0.patch,
> HBASE-18094-master-v1.patch, HBASE-18094-master-v2.patch
>
>
> It is more convenient for users to display the return result of the command
> append.
> {code}
> hbase(main):001:0> append 't1','r1','f1:name','Guangxu'
> CURRENT VALUE = Guangxu
> Took 0.8820 seconds
>
>
> hbase(main):002:0> append 't1','r1','f1:name',' Cheng'
> CURRENT VALUE = Guangxu Cheng
> Took 0.0140 seconds
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
