[
https://issues.apache.org/jira/browse/HBASE-5110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177841#comment-13177841
]
Todd Lipcon commented on HBASE-5110:
------------------------------------
Ah, I missed that thread... I just wanted to clarify if this is for readability
or performance... do you see this function getting called a lot in a write
workload? Your comments on the mailing list thread indicate that it's
performance sensitive, but I don't see how that would be the case.
> code enhancement - remove unnecessary if-checks in every loop in HLog class
> ---------------------------------------------------------------------------
>
> Key: HBASE-5110
> URL: https://issues.apache.org/jira/browse/HBASE-5110
> Project: HBase
> Issue Type: Improvement
> Components: wal
> Affects Versions: 0.90.1, 0.90.2, 0.90.4, 0.92.0
> Reporter: Mikael Sitruk
> Priority: Minor
>
> The HLog class (method findMemstoresWithEditsEqualOrOlderThan) has
> unnecessary if check in a loop.
> static byte [][] findMemstoresWithEditsEqualOrOlderThan(final long
> oldestWALseqid,
> final Map<byte [], Long> regionsToSeqids) {
> // This method is static so it can be unit tested the easier.
> List<byte []> regions = null;
> for (Map.Entry<byte [], Long> e: regionsToSeqids.entrySet()) {
> if (e.getValue().longValue() <= oldestWALseqid) {
> if (regions == null) regions = new ArrayList<byte []>();
> regions.add(e.getKey());
> }
> }
> return regions == null?
> null: regions.toArray(new byte [][] {HConstants.EMPTY_BYTE_ARRAY});
> }
> The following change is suggested
> static byte [][] findMemstoresWithEditsEqualOrOlderThan(final long
> oldestWALseqid,
> final Map<byte [], Long> regionsToSeqids) {
> // This method is static so it can be unit tested the easier.
> List<byte []> regions = new ArrayList<byte []>();
> for (Map.Entry<byte [], Long> e: regionsToSeqids.entrySet()) {
> if (e.getValue().longValue() <= oldestWALseqid) {
> regions.add(e.getKey());
> }
> }
> return regions.size() == 0?
> null: regions.toArray(new byte [][] {HConstants.EMPTY_BYTE_ARRAY});
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
