[
https://issues.apache.org/jira/browse/HBASE-16392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025055#comment-16025055
]
Ted Yu commented on HBASE-16392:
--------------------------------
{code}
+ + "If there is no active backup session is running, run backup
repair utility to restore \n"
{code}
First part of the sentence has double 'is'
{code}
+ finalizeDelete(allTablesMap, sysTable);
+ // Finish
+ sysTable.finishDeleteOperation();
+ // delete snapshot
+ BackupSystemTable.deleteSnapshot(conn);
{code}
Do we need to distinguish potential failure in each of the above calls ?
If deleteSnapshot() fails in the middle,
BackupSystemTable.restoreFromSnapshot(conn) call in catch block would fail as
well, right ?
{code}
+ String[] backupIds = sysTable.getDeleteOperationListOfBackupIds();
{code}
getDeleteOperationListOfBackupIds -> getListOfBackupIdsFromDeleteOperation
{code}
+ System.out.println("Delete operation finished OK");
{code}
Add information about the backup Ids involved.
Please put the next patch on review board.
> Backup delete fault tolerance
> -----------------------------
>
> Key: HBASE-16392
> URL: https://issues.apache.org/jira/browse/HBASE-16392
> Project: HBase
> Issue Type: Sub-task
> Reporter: Vladimir Rodionov
> Assignee: Vladimir Rodionov
> Labels: backup
> Fix For: 2.0.0
>
> Attachments: HBASE-16392-v1.patch
>
>
> Backup delete modified file system and backup system table. We have to make
> sure that operation is atomic, durable and isolated.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
