[ 
https://issues.apache.org/jira/browse/HBASE-18090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026772#comment-16026772
 ] 

Yi Liang commented on HBASE-18090:
----------------------------------

Hi Mikhail,
  I think the patch is good overall, Ted's comments maybe need to be addressed. 
  Just have one question, what if user has implement their own split algo and 
want to use it, and your code seems can not handle those case. 
{code}
+    RegionSplitter.SplitAlgorithm splitAlgo = null;
+    if 
(RegionSplitter.UniformSplit.class.getSimpleName().equals(conf.get(SPLIT_ALGO)))
 {
+      splitAlgo = new RegionSplitter.UniformSplit();
+    } else if 
(RegionSplitter.HexStringSplit.class.getSimpleName().equals(conf.get(SPLIT_ALGO)))
 {
+      splitAlgo = new RegionSplitter.HexStringSplit();
+    }
{code}

> Improve TableSnapshotInputFormat to allow more multiple mappers per region
> --------------------------------------------------------------------------
>
>                 Key: HBASE-18090
>                 URL: https://issues.apache.org/jira/browse/HBASE-18090
>             Project: HBase
>          Issue Type: Improvement
>          Components: mapreduce
>    Affects Versions: 1.4.0
>            Reporter: Mikhail Antonov
>         Attachments: HBASE-18090-branch-1.3-v1.patch
>
>
> TableSnapshotInputFormat runs one map task per region in the table snapshot. 
> This places unnecessary restriction that the region layout of the original 
> table needs to take the processing resources available to MR job into 
> consideration. Allowing to run multiple mappers per region (assuming 
> reasonably even key distribution) would be useful.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to