[
https://issues.apache.org/jira/browse/HBASE-16179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029734#comment-16029734
]
Mike Drob commented on HBASE-16179:
-----------------------------------
{code:title=hbase-spark/pom.xml}
+ <artifactId>hbase-spark-${spark.version}_2.11</artifactId>
+ <name>Apache HBase - Spark 2.0 with Scala 2.11</name>
{code}
This feels like a trap waiting for a future developer to use the variable in
one place and value literal in the next.
{code:title=hbase-spark/src/test/java/org/apache/hadoop/hbase/spark/TestJavaHBaseContext.java}
- jsc.addJar("spark.jar");
+ //jsc.addJar("spark.jar");
{code}
Why comment instead of delete? How does this not break the old tests?
Is {{Logging.scala}} a straight copy from spark? Do we need any sort of
attribution? Should it look more like the datastax connector, since we
shouldn't be doing scary internal initialization stuff anyway?
> Fix compilation errors when building hbase-spark against Spark 2.0
> ------------------------------------------------------------------
>
> Key: HBASE-16179
> URL: https://issues.apache.org/jira/browse/HBASE-16179
> Project: HBase
> Issue Type: Bug
> Components: spark
> Reporter: Ted Yu
> Assignee: Ted Yu
> Priority: Critical
> Labels: build
> Fix For: 2.0.0
>
> Attachments: 16179.v0.txt, 16179.v10.txt, 16179.v11.txt,
> 16179.v12.txt, 16179.v12.txt, 16179.v12.txt, 16179.v13.txt, 16179.v15.txt,
> 16179.v16.txt, 16179.v18.txt, 16179.v19.txt, 16179.v19.txt, 16179.v1.txt,
> 16179.v1.txt, 16179.v20.txt, 16179.v22.txt, 16179.v23.txt, 16179.v24.txt,
> 16179.v25.txt, 16179.v26.txt, 16179.v27.txt, 16179.v4.txt, 16179.v5.txt,
> 16179.v7.txt, 16179.v8.txt, 16179.v9.txt
>
>
> I tried building hbase-spark module against Spark-2.0 snapshot and got the
> following compilation errors:
> http://pastebin.com/bg3w247a
> Some Spark classes such as DataTypeParser and Logging are no longer
> accessible to downstream projects.
> hbase-spark module should not depend on such classes.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
