[
https://issues.apache.org/jira/browse/HBASE-18078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030188#comment-16030188
]
Enis Soztutar commented on HBASE-18078:
---------------------------------------
- You are still calling Future::get() here in the
{{ConnectionFactory::AsyncConnect}}, no?
{code}
+ auto pipeline = client->connect(
+ SocketAddress(hostname, port, true),
+ std::chrono::duration_cast<milliseconds>(connect_timeout_)).get();
{code}
- If this patch is not changing the blocking nature of our TCP connection
establishment, maybe we should not introduce these methods, especially
{{ConnectionPool::AsyncGetNewConnection}} which seems to be a copy of the other
method.
> [C++] Harden RPC by handling various communication abnormalities
> ----------------------------------------------------------------
>
> Key: HBASE-18078
> URL: https://issues.apache.org/jira/browse/HBASE-18078
> Project: HBase
> Issue Type: Sub-task
> Reporter: Xiaobing Zhou
> Assignee: Xiaobing Zhou
> Attachments: HBASE-18078.000.patch, HBASE-18078.001.patch,
> HBASE-18078.002.patch
>
>
> RPC layer should handle various communication abnormalities (e.g. connection
> timeout, server aborted connection, and so on). Ideally, the corresponding
> exceptions should be raised and propagated through handlers of pipeline in
> client.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
